Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove notOpenSSL098 #2173

Merged
merged 2 commits into from
Mar 12, 2021
Merged

Conversation

pquentin
Copy link
Member

Support for OpenSSL 0.9.8 ended in 2016.

Support for OpenSSL 0.9.8 ended in 2016.
@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #2173 (ae86a90) into main (6d799ce) will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #2173      +/-   ##
===========================================
+ Coverage   99.86%   100.00%   +0.13%     
===========================================
  Files          26        25       -1     
  Lines        2256      2250       -6     
===========================================
- Hits         2253      2250       -3     
+ Misses          3         0       -3     
Impacted Files Coverage Δ
src/urllib3/util/ssl_.py 100.00% <0.00%> (ø)
src/urllib3/_compat.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d799ce...ae86a90. Read the comment docs.

sethmlarson
sethmlarson previously approved these changes Mar 10, 2021
Copy link
Member

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the tiniest change is required to make the lint job happy. Merge when desired :)

test/__init__.py Show resolved Hide resolved
@sethmlarson sethmlarson merged commit d3bdb99 into urllib3:main Mar 12, 2021
@pquentin pquentin deleted the remove-notopenssl098 branch September 24, 2021 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants