Always pass server_hostname to wrap_socket#2176
Merged
Merged
Conversation
Since Python 3.5, wrap_socket always allow a server_hostname to be passed, even if OpenSSL does not have SNI. This is how our pyOpenSSL and SecureTransport backends work too.
pquentin
force-pushed
the
server-hostname-exists
branch
from
01bda18 to
12e78cf
Compare
Codecov Report
@@ Coverage Diff @@
## main #2176 +/- ##
==========================================
- Coverage 99.86% 99.86% -0.01%
==========================================
Files 26 26
Lines 2256 2253 -3
==========================================
- Hits 2253 2250 -3
Misses 3 3
Continue to review full report at Codecov.
|
sethmlarson
approved these changes
Mar 10, 2021
sethmlarson
left a comment
sethmlarson
left a comment
Member
There was a problem hiding this comment.
LGTM, this is a great simplification!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Python 3.5, wrap_socket always allows a server_hostname to bepassed, even if OpenSSL does not have SNI. This is how our pyOpenSSL and SecureTransport backends work too.