Move "no SNI if IP address" responsibilty to TLS backends#2177
Closed
pquentin wants to merge 3 commits intourllib3:mainfrom
Closed
Move "no SNI if IP address" responsibilty to TLS backends#2177pquentin wants to merge 3 commits intourllib3:mainfrom
pquentin wants to merge 3 commits intourllib3:mainfrom
Conversation
It won't make a difference in practice, and avoids useless differences.
Codecov Report
@@ Coverage Diff @@
## main #2177 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 25 25
Lines 2250 2246 -4
=========================================
- Hits 2250 2246 -4
Continue to review full report at Codecov.
|
* The ssl module already avoids SNI when the host is an IP address * pyOpenSSL now does that too * We were already using SNI on IP addresses with SecureTransport anyway In other words, this does not change anything, but is cleaner (we no longer test for SecureTransport in ssl.py) and will allow us to lean on ssl.SSLContext to match hostnames.
pquentin
force-pushed
the
sni-in-ssl-backends
branch
from
6c09ab6 to
3fd2be9
Compare
sethmlarson
previously approved these changes
Mar 13, 2021
Member
sethmlarson
left a comment
sethmlarson
left a comment
There was a problem hiding this comment.
The change itself looks good, great to simplify things! One thought:
We already have way too much public functions
Member
Author
|
The codecov check is red, but the coverage is still 100%: https://app.codecov.io/gh/urllib3/urllib3/compare/2177/commits |
sethmlarson
approved these changes
Mar 16, 2021
Member
sethmlarson
left a comment
sethmlarson
left a comment
There was a problem hiding this comment.
Thanks for the change, this looks great now 🎉
Member
Author
|
Was merged as part of #2178 by mistake, closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In other words, this does not change anything, but is cleaner
(we no longer test for SecureTransport in ssl.py) and will allow us to
lean on ssl.SSLContext to match hostnames.