Actually reject common names #2186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were using Python's match_hostname by default, who accepts them.
Codecov Report
@@ Coverage Diff @@
## main #2186 +/- ##
===========================================
- Coverage 100.00% 99.82% -0.18%
===========================================
Files 25 25
Lines 2249 2249
===========================================
- Hits 2249 2245 -4
- Misses 0 4 +4
Continue to review full report at Codecov.
|
sethmlarson
reviewed
Mar 16, 2021
| certs = TLSv1_3_CERTS | ||
|
|
||
|
|
||
| class TestHTTPS_NoSAN: |
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using Python's match_hostname by default, who accepts them.
The next step is to move ssl_match_hostname from packages to util, but that would make a nice first issue so I left it out.