Configure pytest, isort and mypy in pyproject.toml #2785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pquentin
changed the title
pquentin
added
the
Skip Changelog
hramezani
approved these changes
Nov 10, 2022
hramezani
previously approved these changes
Nov 10, 2022
graingert
previously approved these changes
Nov 10, 2022
|
It wasn't confusion, I just missed it. It's easy to do that when there is multiple places you could put these settings. Like It's a shame flake8 won't move to |
|
Sure, both of you could have searched but you didn't and used pyproject.toml. So we have empirical data showing that preferring pyproject.toml will help contributors! |
pquentin
dismissed stale reviews from sethmlarson, graingert, and hramezani
via
eb0d651
sethmlarson
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this was a contributor friendly issue but #2780 and #2784 both got confused about this, adding settings in pyproject.toml for pytest and isort respectively, so I've decided to just do it myself to avoid more problems with this in the future.
Closes #2773