Explicitly chain exceptions in HTTPConnectionPool._make_request #2866
Conversation
zhanpon
force-pushed
the
chain-exceptions
branch
from
4109122
to
94990e3
Compare
|
@sethmlarson @pquentin Would you mind take a look? This one should be straightforward. |
ecerulm
added
the
Skip Changelog
| @@ -489,7 +489,7 @@ def _make_request( | |||
| new_e, (OSError, NewConnectionError, TimeoutError, SSLError) | |||
| ) and (conn and conn.proxy and not conn.has_connected_to_proxy): | |||
| new_e = _wrap_proxy_error(new_e, conn.proxy.scheme) | |||
| raise new_e | |||
| raise new_e from e | |||
There was a problem hiding this comment.
_wrap_proxy_error does already explicitly set the __cause__ and raise new_e from e will overwrite that __cause__
so in the case of e being a CertificateError the current code can produce ProxyError -> SSLError -> CertificateError but with this change it will produce ProxyError -> CertificateError instead.
So I think in this case if we really would like to get the "The above exception was the direct cause of the following exception:" instead of "During handling of the above exception, another exception occurred:" would be better to set new_e.__cause__ explicitly after the SSLError.
Reference https://docs.python.org/3/library/exceptions.html#exception-context
|
@zhanpon, I'm closing this issue as per my other comment, feel free to reopen it you disagree. |
Fix #2313. I didn't search other places for the issue, so there might be other
raisestatements that can be improved as well.I skipped a changelog entry to be consistent with #2340.