Use coverage sys.monitoring for a speed-boost #3255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethmlarson
added
the
Skip Changelog
|
Nice! According to https://mastodon.social/@hugovk/111657679446754746 this option only works on Python 3.12 for now. |
|
@pquentin Yeah I forgot to upgrade our coverage dependency, resolving that issue now locally. |
pquentin
approved these changes
Jan 1, 2024
| # In coverage 7.4.0 we can only set the setting for Python 3.12+ | ||
| # Future versions of coverage will use sys.monitoring based on availability. | ||
| if ( | ||
| isinstance(session.python, str) |
There was a problem hiding this comment.
In what case is this not a string?
There was a problem hiding this comment.
This is mostly to make type hints happy, apparently the type of session.python is True | None | str.
|
All of the 3.12 jobs passed, merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New in coverage 7.4.0! See: https://nedbatchelder.com/blog/202312/coveragepy_with_sysmonitoring.html