Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary OpenSSL 1.1.1 matrix, push branch jobs #3256

Merged
merged 4 commits into from Jan 3, 2024
Merged

Remove unnecessary OpenSSL 1.1.1 matrix, push branch jobs #3256

merged 4 commits into from Jan 3, 2024

Conversation

sethmlarson
Copy link
Member

Maintain the Python 3.8 + OpenSSL job, drop the rest as a waste of CI resources.

@sethmlarson sethmlarson added the Skip Changelog Pull requests that don't require a changelog entry label Jan 1, 2024
pquentin
pquentin previously approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM. I'd like to know what @illia-v thinks too.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
@sethmlarson
Copy link
Member Author

Thanks for the review, I'll wait for @illia-v to merge :)

illia-v
illia-v approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@illia-v illia-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@illia-v illia-v merged commit 2ac4efa into main Jan 3, 2024
58 of 62 checks passed
@illia-v illia-v deleted the optimize-ci-push-openssl-1.1.1 branch January 3, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illia-v illia-v illia-v approved these changes

@shazow shazow Awaiting requested review from shazow shazow is a code owner

@pquentin pquentin Awaiting requested review from pquentin pquentin is a code owner

Assignees
No one assigned
Labels
Skip Changelog Pull requests that don't require a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sethmlarson @pquentin @illia-v