Adding a Makefile #415
Closed
Adding a Makefile #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Gonna use this to push out v1.8.3 tomorrow morning, let's see what kind of disaster that causes. |
| piprot: requirements | ||
| piprot -x $(REQUIREMENTS_FILE) | ||
|
|
||
| $(REQUIREMENTS_OUT): $(REQUIREMENTS_FILE) |
There was a problem hiding this comment.
I can't follow... looking for a $(REQUIREMENTS_FILE) as a target and not seeing one.
There was a problem hiding this comment.
I've been using this for other projects for some years now, it's very handy. Basically it only tries to install new requirements if the requirements.txt file is newer than the requirements.txt.log file.
|
Sadly making Sphinx a requirement makes travisci in Py3 (~4min) run way slower than Py2 (~25s). |
|
Merged in f6a0e96. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly stolen from #317. (Thanks @kevinburke! Thoughts?)
Was considering doing separate
dev-requirements.txt(sphinx, piprot, etc) andtest-requirements.txt(nose, tox, etc) but... so many requirements. :(Then again, we want travisci and co to fail when sphinx build fails (maybe also when piprot says things are out of date?) #414, so merging these things might be a Good Thing.
The plan is to add my release routine in here, too.