Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix file descriptor leak due to stack frame reference #549
referenced this pull request
Feb 14, 2015
So it'd be excellent if there were a test for this, but I don't know how you would begin to test this in the context of urllib3's test suite. That said, @shazow or @Lukasa should definitely be more helpful in that regard. The one thing I'd request is that you leave a comment near the
Also, I think those test failures are purely Travis' fault but if they continue, we may need to look further into why they're failing.
I suspect the way to test this is to test the cause of what we're fixing. Actually demonstrating a reference cycle in a test is a bit tricky, but you can test that the frame local variables don't have the stacktrace. Bit of a tricky test to write, but if we think it's important it's totally do-able.