chore: Upgrade webpack and graphql dependencies #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValGeorgiev
changed the title
| @@ -1,3 +1,4 @@ | |||
| { | |||
| "silent": true | |||
| "silent": true, | |||
| "node": "14" | |||
| fs: "empty", | ||
| fallback: { | ||
| fs: false, | ||
| path: false, |
There was a problem hiding this comment.
Non blocking - any idea what update caused us to need to use path in the browser?
There was a problem hiding this comment.
I am facing this issue when I build cosmos with webpack 5
I will upgrade electron later and check if this is still needed
There was a problem hiding this comment.
Interesting - can you try building cosmos but changing this to be BUILD_ENV=extension - https://github.com/FormidableLabs/urql-devtools/blob/master/package.json#L25
I can't think of any good reason as to why we would want to use the electron version of the devtools in cosmos (other than me being a pleb and mixing up the two)
andyrichardson
approved these changes
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade webpack and graphql dependencies with this PR.
I need to downgrade react-spring because of CSP issue (more details here: pmndrs/react-spring#1423)
Remove Maybe graphql type because it's internal for them now and it should not be used. (more insights here: graphql/graphql-js#2621 (comment))
There is a weird issue with our visual regression tests when I upgrade the puppeteer docker image, so I will skip that and do in another PR
Otherwise, all looks great and tested on both web and RN