Skip to content

Drop some compat for python < 2.6#409

Merged
penguinolog merged 3 commits intourwid:masterfrom
dlax:drop-old-py2-compat
Mar 28, 2023
Merged

Drop some compat for python < 2.6#409
penguinolog merged 3 commits intourwid:masterfrom
dlax:drop-old-py2-compat

Conversation

@dlax
Copy link
Contributor

@dlax dlax commented Jun 6, 2020

Checklist
  • I've ensured that similar functionality has not already been implemented
  • I've ensured that similar functionality has not earlier been proposed and declined
  • I've branched off the master or python-dual-support branch
  • I've merged fresh upstream into my branch recently
  • I've ran tox successfully in local environment
  • I've included docstrings and/or documentation and/or examples for my code (if this is a new feature)
Description:

Per changelog, support for python 2.4 and 2.5 got dropped in version 1.2.0 but there remained some compat code, some of which is here dropped. One step towards #394.

dlax added 2 commits June 6, 2020 11:35
Support for python 2.4 and 2.5 got dropped in version 1.2.0.
Also, these declarations confuse mypy.
@coveralls
Copy link

coveralls commented Jun 6, 2020

Coverage Status

Coverage increased (+0.4%) to 77.832% when pulling 5edca66 on dlax:drop-old-py2-compat into c93aeb2 on urwid:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 77.898% when pulling f2b927e on dlax:drop-old-py2-compat into 2cc5489 on urwid:master.

Copy link
Collaborator

@ulidtko ulidtko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM.

Sorry it took so long to review this, that a conflict appeared (ironically, with another py2/3 compatibility-related commit).

It's a simple 1-line conflict in imports though. I've solved it using GitHub web UI. Merging as soon as tests pass.

@ulidtko
Copy link
Collaborator

ulidtko commented Mar 18, 2021

Hmmm... GitHub doesn't show it for some reason, but there're bytes-related test failures on Py 3.5 & 3.6 — see Travis CI https://travis-ci.org/github/urwid/urwid/builds/763275814

@dlax
Copy link
Contributor Author

dlax commented Mar 19, 2021

The failure comes from master; see, e.g., https://travis-ci.org/github/urwid/urwid/builds/758944725

@penguinolog penguinolog merged commit 32c4623 into urwid:master Mar 28, 2023
@dlax dlax deleted the drop-old-py2-compat branch March 28, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants