Drop some compat for python < 2.6#409
Merged
penguinolog merged 3 commits intourwid:masterfrom Mar 28, 2023
Merged
Conversation
Support for python 2.4 and 2.5 got dropped in version 1.2.0. Also, these declarations confuse mypy.
5 tasks
ulidtko
approved these changes
Mar 17, 2021
Collaborator
ulidtko
left a comment
There was a problem hiding this comment.
Nice! LGTM.
Sorry it took so long to review this, that a conflict appeared (ironically, with another py2/3 compatibility-related commit).
It's a simple 1-line conflict in imports though. I've solved it using GitHub web UI. Merging as soon as tests pass.
Collaborator
|
Hmmm... GitHub doesn't show it for some reason, but there're bytes-related test failures on Py 3.5 & 3.6 — see Travis CI https://travis-ci.org/github/urwid/urwid/builds/763275814 |
Contributor
Author
|
The failure comes from master; see, e.g., https://travis-ci.org/github/urwid/urwid/builds/758944725 |
penguinolog
approved these changes
Mar 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
masterorpython-dual-supportbranchtoxsuccessfully in local environmentDescription:
Per changelog, support for python 2.4 and 2.5 got dropped in version 1.2.0 but there remained some compat code, some of which is here dropped. One step towards #394.