Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore resetting to invalid locale (Closes: #377) #415

Merged
merged 1 commit into from Aug 9, 2020

Conversation

jspricke
Copy link
Contributor

@jspricke jspricke commented Jun 26, 2020

Checklist
  • I've ensured that similar functionality has not already been implemented
  • I've ensured that similar functionality has not earlier been proposed and declined
  • I've branched off the master or python-dual-support branch
  • I've merged fresh upstream into my branch recently
  • I've ran tox successfully in local environment
    - [ ] I've included docstrings and/or documentation and/or examples for my code (if this is a new feature)
Description:

Resetting the locale was introduced in 5dcf236, before that an invalid
locale was ignored. Restore the old behavior insofar that only valid
locales are restored.
This fixes the unit tests of scottkosty/vit with unset LANG.

Resetting the locale was introduced in 5dcf236, before that an invalid
locale was ignored. Restore the old behavior insofar that only valid
locales are restored.
This fixes the unit tests of scottkosty/vit with unset LANG.
@coveralls
Copy link

coveralls commented Jun 26, 2020

Coverage Status

Coverage decreased (-0.01%) to 77.852% when pulling fd010f8 on jspricke:try_setlocale into 56194f9 on urwid:master.

@jspricke jspricke changed the title Ignore setting resetting to invalid locale (Closes: #377) Ignore resetting to invalid locale (Closes: #377) Jun 26, 2020
@jspricke
Copy link
Contributor Author

An example of the broken test can be found here:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=963315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants