-
Notifications
You must be signed in to change notification settings - Fork 320
Add two fonts based on Unicode 13 2x3 TRS-80/Teletext mosaic characters #434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -77,6 +77,7 @@ static const int widths[] = { | |||
65500, 1, | |||
65510, 2, | |||
120831, 1, | |||
130047, 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interim fix
@@ -72,6 +72,7 @@ | |||
(65500, 1), | |||
(65510, 2), | |||
(120831, 1), | |||
(130047, 1), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interim fix
If a proper fix to #225 takes too long, can we merge this as is? |
Hi @urwid folks. This has been sitting here for quite some time. The characters used are supported directly by terminals based on VTE (Gnome Terminal and others), QtTermWidget (Konsole, etc). Can we merge this? |
Hi, @ulidtko, do you think this is mergeable? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validated, fonts rendered correctly.
Interim changes is required in current moment.
I've bad news. I just did a fresh install and the examples/bigtext.py program that showcases the new fonts is failing with a
I'll see if I can add a fix and a test to prevent this regression. |
This issue is not produced by changes in this PR (happens on almost all fonts) |
Real issue is caused by encoding to bytes, when equal length Unicode strings became not equal length byte strings and |
Are you sure it's related to that issue? |
Checklist
master
orpython-dual-support
branchtox
successfully in local environmentDescription:
Add two fonts, one with small digits with a 3x5 on 4x6 matrix, and another with a 5x7 on 6x9 matrix characters to the font.py file. These characters use recently added Unicode 13 symbols.
The PR has two small interim fixes for character width calculation that allow it to run, but that should be removed before merging (it can't be merged before #225 is fixed).