Skip to content

fix: use trio.lowlevel instead of trio.hazmat with Trio >= 0.15 #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2021

Conversation

ntamas
Copy link
Contributor

@ntamas ntamas commented Nov 2, 2020

Checklist
  • I've ensured that similar functionality has not already been implemented
  • I've ensured that similar functionality has not earlier been proposed and declined
  • I've branched off the master or python-dual-support branch
  • I've merged fresh upstream into my branch recently
  • I've ran tox successfully in local environment
  • I've included docstrings and/or documentation and/or examples for my code (if this is a new feature)
Description:

This PR gets rid of two deprecation warnings that appear when TrioEventLoop is used in conjunction with trio >= 0.15. Trio 0.15 deprecated the trio.hazmat module in favour of trio.lowlevel.

@coveralls
Copy link

coveralls commented Nov 2, 2020

Coverage Status

Coverage decreased (-0.04%) to 77.833% when pulling a57465c on collmot:fix/trio-hazmat-deprecation-warning into 4c739b6 on urwid:master.

@ntamas
Copy link
Contributor Author

ntamas commented Jan 16, 2021

Note that trio 0.18 has now removed the deprecated trio.hazmat module so TrioEventLoop will not work with Trio >= 0.18 until this PR is merged.

@sarnold sarnold mentioned this pull request Feb 9, 2021
3 tasks
@pquentin
Copy link

pquentin commented Feb 9, 2021

This pull request is fine, but it's probably simpler to just use trio.lowlevel, trio 0.15 is now pretty old by trio standards.

@tonycpsu
Copy link
Collaborator

Thanks, and sorry for the delay in merging.

@tonycpsu tonycpsu merged commit c93aeb2 into urwid:master Feb 14, 2021
@ntamas ntamas deleted the fix/trio-hazmat-deprecation-warning branch February 14, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants