Skip to content

Include _resize_pipe_rd in fd_list for _wait_for_input_ready for raw_display - #453

Merged
penguinolog merged 1 commit into
urwid:masterfrom
inducer:sigwinch-raw-wait-for-input
Mar 28, 2023
Merged

Include _resize_pipe_rd in fd_list for _wait_for_input_ready for raw_display#453
penguinolog merged 1 commit into
urwid:masterfrom
inducer:sigwinch-raw-wait-for-input

Conversation

@inducer

@inducer inducer commented Jan 14, 2021

Copy link
Copy Markdown
Contributor
Checklist
  • I've ensured that similar functionality has not already been implemented
  • I've ensured that similar functionality has not earlier been proposed and declined
  • I've branched off the master or python-dual-support branch
  • I've merged fresh upstream into my branch recently
  • I've ran tox successfully in local environment
  • I've included docstrings and/or documentation and/or examples for my code (if this is a new feature)
Description:

This addresses inducer/pudb#421 (at least for the raw display). Pudb uses its own main loop, and I noticed that it didn't receive events for window resizes, instead receiving those only on the next key press.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.7%) to 77.138% when pulling 228ffee on inducer:sigwinch-raw-wait-for-input into 4c739b6 on urwid:master.

@wookayin

Copy link
Copy Markdown

Dear maintainers, a gentle reminder of this! It'd be great if this can be merged sooner than later. /cc @ulidtko

@wookayin

wookayin commented Jan 3, 2023

Copy link
Copy Markdown

Any updates?

@penguinolog
penguinolog merged commit 2c0c0eb into urwid:master Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants