Skip to content

Use locale.getpreferredencoding(False) if possible (most systems) F…#528

Merged
penguinolog merged 1 commit intourwid:masterfrom
penguinolog:fix_locale_tests
Apr 3, 2023
Merged

Use locale.getpreferredencoding(False) if possible (most systems) F…#528
penguinolog merged 1 commit intourwid:masterfrom
penguinolog:fix_locale_tests

Conversation

@penguinolog
Copy link
Collaborator

@penguinolog penguinolog commented Apr 3, 2023 •
edited
Loading

Fix #436 Fix #479

  • Handle impossibility to set locale in tests (docker container scenario)
  • detect_encoding start from non-destructive behavior (do not change locale) and restore exact locale in destructive
Checklist
  • I've ensured that similar functionality has not already been implemented
  • I've ensured that similar functionality has not earlier been proposed and declined
  • I've branched off the master or python-dual-support branch
  • I've merged fresh upstream into my branch recently
  • I've ran tox successfully in local environment

@penguinolog
Use locale.getpreferredencoding(False) if possible (most systems) Fix
e1b7697 
urwid#436 Fix urwid#479

* Handle impossibility to set locale in tests
  (docker container scenario)
* `detect_encoding` start from non-destructive behavior
  (do not change locale)
  and restore exact locale in destructive
@penguinolog penguinolog merged commit 2d27ffc into urwid:master Apr 3, 2023
@penguinolog penguinolog deleted the fix_locale_tests branch April 3, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Importing urwid breaks strptime() because of locale test_locale test assumes en_US.UTF8 locale is available

1 participant

@penguinolog