Skip to content

Fix input handling and extra type annotations #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2023
Merged

Fix input handling and extra type annotations #530

merged 1 commit into from
Apr 5, 2023

Conversation

penguinolog
Copy link
Collaborator

  • keypress always receive str
  • fix CF635Screen: was missed return parameter in get_input_nonblocking
  • fix LCDScreen: wrong type used for buffer (pyserial return bytes, concatenation to str is wrong)

Partial #406
Partial #512
Related #408

Checklist
  • I've ensured that similar functionality has not already been implemented
  • I've ensured that similar functionality has not earlier been proposed and declined
  • I've branched off the master or python-dual-support branch
  • I've merged fresh upstream into my branch recently
  • I've ran tox successfully in local environment

Fix input handling and extra type annotations
b85306c 
* keypress always receive `str`
* fix `CF635Screen`: was missed return parameter in get_input_nonblocking
* fix `LCDScreen`: wrong type used for buffer (pyserial return `bytes`, concatenation to `str` is wrong)

Partial urwid#406
Partial urwid#512
Related urwid#408
@penguinolog penguinolog added Feature Feature request/implementation bug refactoring python3 labels Apr 5, 2023
@penguinolog penguinolog merged commit 9976f33 into urwid:master Apr 5, 2023
@penguinolog penguinolog deleted the fix_inputh_handling branch April 5, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Feature Feature request/implementation refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@penguinolog