Deprecate legacy property creation #533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Drop long time ago removed methods (never returning methods) * Move large part of property implementations under `@property` * Emit `PendingDeprecationWarning` for old compatibility code for public methods used as core for property and methods for compatibility * Emit `DeprecationWarning` for private methods used in property construction using `property()` call Due to amount of copy-paste like changes, for containers shared part is moved to the existing base classes Add `__len__` to the list based containers. Related urwid#445 Fix typo in type annotation for `Frame.mouse_event`
wardi
reviewed
Apr 11, 2023
wardi
reviewed
Apr 11, 2023
Co-authored-by: Ian Ward <ian@excess.org>
Co-authored-by: Ian Ward <ian@excess.org>
wardi
reviewed
Apr 11, 2023
Co-authored-by: Ian Ward <ian@excess.org>
…m pre-property era Make consistent with other containers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@propertyPendingDeprecationWarningfor old compatibility code for public methods used as core for property and methods for compatibilityDeprecationWarningfor private methods used in property construction usingproperty()callDue to amount of copy-paste like changes, for containers shared part is moved to the existing base classes Add
__len__to the list based containers. Related #445 Fix typo in type annotation forFrame.mouse_eventChecklist
masterorpython-dual-supportbranchtoxsuccessfully in local environment