Add type annotations and optimize urwid.font - #540
Merged
Conversation
penguinolog
commented
Apr 18, 2023
| ) -> str: | ||
| if isinstance(obj, str): | ||
| return obj | ||
| elif isinstance(obj, bytes): |
Collaborator
Author
There was a problem hiding this comment.
double transcoding is a bit overkill, just use strings directly
* optimize `separate_glyphs`: do not mutate `gl`, less temporary variables * add `__repr__` and human-friendly exception reraise on render * add type annotations to satisfy mypy Partial: urwid#406
penguinolog
force-pushed
the
font_annotate_optimize
branch
from
April 19, 2023 07:17
1bee0d6 to
aeb07b2
Compare
penguinolog
force-pushed
the
font_annotate_optimize
branch
from
April 19, 2023 07:43
aeb07b2 to
6593a99
Compare
Collaborator
Author
|
Font list output (changes: |
wardi
approved these changes
Apr 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
separate_glyphs: do not mutategl, less temporary variables__repr__and human-friendly exception reraise on renderPartial: #406
Checklist
masterorpython-dual-supportbranchtoxsuccessfully in local environment