Return original code to the deprecated getters and setters #549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make more aggressive deprecation warning Fix: urwid#548
penguinolog
force-pushed
the
deprecated_getters_setters
branch
from
92551b3 to
2d28599
Compare
* Make more aggressive deprecation warning Fix: urwid#548
penguinolog
commented
May 1, 2023
| @@ -60,6 +61,7 @@ def read(self, size: int) -> bytes: | |||
|
|
|||
| def write(self, data: bytes) -> None: | |||
| os.write(self.writer, data) | |||
| sleep(0.025) | |||
There was a problem hiding this comment.
fix for stable failing tests, btw it's also present in dedicated to vterm PR
penguinolog
commented
May 1, 2023
| ) | ||
| return self.contents | ||
| return self |
There was a problem hiding this comment.
== self.contents, but have to maintain copy-paste during deprecation period
wardi
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #548
Checklist
masterorpython-dual-supportbranchtoxsuccessfully in local environment