Fix CheckBox default state validation and initialization #553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penguinolog
commented
May 5, 2023
| @@ -257,15 +270,12 @@ def set_state(self, state: bool | Literal['mixed'], do_callback: bool = True) -> | |||
| # self._state is None is a special case when the CheckBox | |||
| # has just been created | |||
| old_state = self._state | |||
| if do_callback and old_state is not None: | |||
There was a problem hiding this comment.
old_state is not None beacause explicit initialization used
penguinolog
commented
May 5, 2023
|
|
||
| # Initial create expect no callbacks call, create explicit | ||
| super().__init__( | ||
| Columns( |
There was a problem hiding this comment.
explicit full init -> no "semi-initialized state"
penguinolog
commented
May 5, 2023
| """ | ||
| super().__init__(None) # self.w set by set_state below | ||
| self._label = Text("") |
There was a problem hiding this comment.
we can set all in 1 call instead of chain "construct empty -> call helper to call modifier to replace value from constructor"
penguinolog
commented
May 5, 2023
| [...'[X] Extra onions '] | ||
| >>> cb.render((20,), focus=True).text | ||
| [b'[X] Extra onions '] | ||
| >>> CheckBox("Test", None) |
wardi
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #552
Checklist
masterorpython-dual-supportbranchtoxsuccessfully in local environment