Fix TextCanvas CanvasError("Attribute extends beyond text...")
#555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `[[]] * ...` causes list of 1 list with pointers amount equal to multiplier instead of "list of lists" * Add 2 basic font tests which check for Canvas create issue * Add few type annotations during debug process Fix: urwid#554
Tests order change should not cause tests failures
penguinolog
commented
May 8, 2023
| maxcol = 0 | ||
|
|
||
| if attr is None: | ||
| attr = [[]] * len(text) |
penguinolog
commented
May 8, 2023
| keys = None | ||
| while keys!=['q']: | ||
| r.text=([t.ljust(cols) for t in text]+[""]*rows)[:rows] | ||
| r.attr=(attr+[[]]*rows) [:rows] |
Collaborator
Author
There was a problem hiding this comment.
place for the same issue
penguinolog
commented
May 8, 2023
| expected = ' ┐ \n │ \n ┴ ' | ||
| self.assertEqual(expected, rendered) | ||
|
|
||
| def test_002_non_rect(self): |
Collaborator
Author
There was a problem hiding this comment.
this test should crash without fix for issue
penguinolog
commented
May 8, 2023
| class CalcBreaksDBCharTest(CalcBreaksTest, unittest.TestCase): | ||
| def setUp(self): | ||
| self.old_encoding = urwid.util._target_encoding | ||
| urwid.set_encoding("euc-jp") |
Collaborator
Author
There was a problem hiding this comment.
this encoding leaked to the other tests without cleanup stage
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[[]] * ...causes list of 1 list with pointers amount equal to multiplier instead of "list of lists"Fix: #554
Checklist
masterorpython-dual-supportbranchtoxsuccessfully in local environment