Fix alternate/normal screen buffer switch for raw display - #556
Merged
penguinolog merged 1 commit intoMay 19, 2023
Merged
Conversation
- Fix: Switch terminal screen buffers for raw display using `1049` DEC Private Mode instead of DECSC/DECRC + `47` DEC Private Mode. Fixes urwid#521
3 tasks
|
Thanks @AnonymouX47, I can confirm this fixes the issue in #521. Tested with MacOS/Terminal and Linux/XTerm. |
penguinolog
approved these changes
May 19, 2023
This was referenced May 19, 2023
AnonymouX47
added a commit
to AnonymouX47/termvisage
that referenced
this pull request
May 21, 2024
- Change: Remove the workaround for urwid not properly switching to and from the alternate screen buffer. Fixed in urwid [v2.2.0](https://github.com/urwid/urwid/releases/tag/2.2.0) by urwid/urwid#556.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
masterorpython-dual-supportbranchtoxsuccessfully in local environmentDescription:
Fixes #487, #521
The XTerm Control Sequences documentation of both the Set and Reset of the
1049DEC Private Mode (CSI ? 1049 h/l) state:This restores the normal screen buffer correctly on Xterm and Alacritty, both of which don't restore the normal buffer with
CSI ? 47 l. Also, the1049mode should work just fine on virtually every [maintained] terminal emulator on which the47mode works.