vterm: Fixed OSC 0,2 to set widget title properly (decode bytestring)#561
Merged
penguinolog merged 1 commit intourwid:masterfrom Jun 3, 2023
danschwarz:vterm_fix_set_title
Merged
vterm: Fixed OSC 0,2 to set widget title properly (decode bytestring)#561penguinolog merged 1 commit intourwid:masterfrom danschwarz:vterm_fix_set_title
penguinolog merged 1 commit intourwid:masterfrom
danschwarz:vterm_fix_set_title
Conversation
danschwarz
changed the title
These are xterm proprietary OSC sequences. per https://www.xfree86.org/current/ctlseqs.html: 0,2 set window title (and 2 sets icon title, but that's irrelevant) 1 sets icon title, which we don't support 3 sets arbitrary window properties, which we don't support The previous code set the widget title using a bytestring this led to visual artifacts. Now we send a proper string.
danschwarz
changed the title
penguinolog
approved these changes
Jun 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
masterorpython-dual-supportbranchtoxsuccessfully in local environmentDescription:
These are xterm proprietary OSC sequences.
per https://www.xfree86.org/current/ctlseqs.html:
0, 2 set window title (and 2 sets icon title, but that's irrelevant)
1 sets icon title, which we don't support
3 sets arbitrary window properties, which we don't support. It shouldn't be setting the title.
The old code was sending the raw bytestring to
widget.set_titlewhich was bad. Now it decodes the bytestring before sending.