Vterm now emits 'resize' signal upon terminal resize - #584
Merged
Conversation
Contributor
Author
|
Code seem to work well. I attempted to add the following test to |
examples/terminal.py has been updated to handle the 'resize' signal, and uses it to display the terminal height x width. This is useful for testing purposes if you want to test vterm at a particular size.
penguinolog
approved these changes
Aug 14, 2023
penguinolog
left a comment
Collaborator
There was a problem hiding this comment.
I'll try to investigate tests ASAP
Contributor
Author
|
Thanks. Good to see you back! Hoping for a new Urwid release in the near future? |
Collaborator
|
Looks like need to release "binary only 3.7 ≤ python ≤ 3.11and later fix python 3.12+ unicode compatibility (new API was in python 3 almost forever, old was because of python 2) |
Collaborator
|
Issue for tests write was created (for resize test is a bit not trivial) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Checklist
masterorpython-dual-supportbranchtoxsuccessfully in local environmentDescription:
Vterm now emits 'resize' signal upon terminal resize, with a (height, width) tuple of the new size.
examples/terminal.py has been updated to handle the 'resize' signal, and uses it to display the terminal height x width. This is useful for testing purposes if you want to test vterm at a particular size.