Skip to content

examples/terminal.py can run against older versions of Urwid again #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2023
Merged

examples/terminal.py can run against older versions of Urwid again #596

merged 1 commit into from
Aug 19, 2023

Conversation

danschwarz
Copy link
Contributor

@danschwarz danschwarz commented Aug 19, 2023

Checklist
  • I've ensured that similar functionality has not already been implemented
  • I've ensured that similar functionality has not earlier been proposed and declined
  • I've branched off the master or python-dual-support branch
  • I've merged fresh upstream into my branch recently
  • I've ran tox successfully in local environment
  • I've included docstrings and/or documentation and/or examples for my code (if this is a new feature)
Description:

terminal.py now enables bracketed paste mode and shows columns/rows when run against the latest Urwid library which supports those features. When run against older versions, it will now disable those features rather than throw an exception.

Also, improved documentation for raw_display.Screen. I am not sure how to test that the new documentation is working correctly, as it doesn't generate the HTML pages on my local system. The changes should be visible on the new version of this page

terminal.py now enables bracketed paste mode and shows columns/rows
when run against the latest Urwid library which supports those
features. When run against older versions, it will now disable
those features rather than throw an exception.

Also, improved documentation for raw_display.Screen
@coveralls
Copy link

Coverage Status

coverage: 73.458%. remained the same when pulling f372c89 on danschwarz:smallfix into a8c0d71 on urwid:master.

@penguinolog penguinolog merged commit ff1543c into urwid:master Aug 19, 2023
@danschwarz danschwarz deleted the smallfix branch August 19, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants