Skip to content

Pass SelectableIcon align and wrap arguments to parent #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 6, 2023
Merged

Pass SelectableIcon align and wrap arguments to parent #599

merged 4 commits into from
Sep 6, 2023

Conversation

penguinolog
Copy link
Collaborator

Checklist
  • I've ensured that similar functionality has not already been implemented
  • I've ensured that similar functionality has not earlier been proposed and declined
  • I've branched off the master or python-dual-support branch
  • I've merged fresh upstream into my branch recently
  • I've ran tox successfully in local environment
  • I've included docstrings and/or documentation and/or examples for my code (if this is a new feature)

Feat #494 #355

Aleksei Stepanov added 2 commits September 5, 2023 10:40
@penguinolog penguinolog added the Feature Feature request/implementation label Sep 5, 2023
@penguinolog penguinolog linked an issue Sep 5, 2023 that may be closed by this pull request
pass arguments to SelectableIcon() to parent #495
Closed
3 tasks
@penguinolog penguinolog requested a review from wardi September 5, 2023 09:16
Expose align and wrap mode to the button
7ea051d 
Common reason for own `Button` implementation is impossibility to set align/wrap
wardi
wardi reviewed Sep 5, 2023
View reviewed changes
@penguinolog penguinolog requested a review from wardi September 5, 2023 13:41
@penguinolog penguinolog merged commit 9148589 into urwid:master Sep 6, 2023
@penguinolog penguinolog deleted the selectable_icon branch September 6, 2023 06:48
This was referenced Sep 6, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wardi wardi Awaiting requested review from wardi

Assignees
No one assigned
Labels
Feature Feature request/implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pass arguments to SelectableIcon() to parent
2 participants
@penguinolog @wardi