Skip to content

Pass SelectableIcon align and wrap arguments to parent#599

Merged
penguinolog merged 4 commits into
urwid:masterfrom
penguinolog:selectable_icon
Sep 6, 2023
Merged

Pass SelectableIcon align and wrap arguments to parent#599
penguinolog merged 4 commits into
urwid:masterfrom
penguinolog:selectable_icon

Conversation

@penguinolog

Copy link
Copy Markdown
Collaborator
Checklist
  • I've ensured that similar functionality has not already been implemented
  • I've ensured that similar functionality has not earlier been proposed and declined
  • I've branched off the master or python-dual-support branch
  • I've merged fresh upstream into my branch recently
  • I've ran tox successfully in local environment
  • I've included docstrings and/or documentation and/or examples for my code (if this is a new feature)

Feat #494 #355

@penguinolog penguinolog added the Feature Feature request/implementation label Sep 5, 2023
@penguinolog penguinolog linked an issue Sep 5, 2023 that may be closed by this pull request
3 tasks
@penguinolog
penguinolog requested a review from wardi September 5, 2023 09:16
Common reason for own `Button` implementation is impossibility to set align/wrap
Comment thread urwid/widget/wimp.py
@penguinolog
penguinolog requested a review from wardi September 5, 2023 13:41
@penguinolog
penguinolog merged commit 9148589 into urwid:master Sep 6, 2023
@penguinolog
penguinolog deleted the selectable_icon branch September 6, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Feature request/implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pass arguments to SelectableIcon() to parent

2 participants