Typing: Extend wimp typing annotations - #604
Merged
penguinolog merged 1 commit intoSep 22, 2023
Merged
Conversation
penguinolog
commented
Sep 13, 2023
| # Initial create expect no callbacks call, create explicit | ||
| super().__init__( | ||
| Columns( | ||
| [(Sizing.FIXED, self.reserve_columns, self.states[state]), self._label], |
Collaborator
Author
There was a problem hiding this comment.
following Columns it's legacy API for GIVEN element sizing settings
penguinolog
commented
Sep 13, 2023
| # (this variable is picked up by the MetaSignals metaclass) | ||
| signals: typing.ClassVar[list[str]] = ["change", "postchange"] | ||
|
|
||
| @typing.overload |
Collaborator
Author
There was a problem hiding this comment.
decorated code is only type annotation explaining difference for useful argument types depending on has_mixed and user_data
penguinolog
commented
Sep 13, 2023
| self, | ||
| group: MutableSequence[CheckBox], | ||
| label, | ||
| state: bool | Literal["mixed", "first True"] = "first True", |
Collaborator
Author
There was a problem hiding this comment.
mixed is incorrect state because by default has_mixed is false and change possibility is not public exposed
penguinolog
force-pushed
the
typing_radiobutton_checkbox
branch
2 times, most recently
from
September 22, 2023 15:19
2d58c97 to
90ed3f8
Compare
Add overload info for constructors of: * `CheckBox` * `RadioButton` * `Button` Fix info for `Columns` constructor (`GIVEN` size) Fix info for `Pile` constructor
penguinolog
force-pushed
the
typing_radiobutton_checkbox
branch
from
September 22, 2023 15:24
90ed3f8 to
db7d55a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add overload info for constructors of:
CheckBoxRadioButtonButtonFix info for
Columnsconstructor (GIVENsize)Checklist
masterorpython-dual-supportbranchtoxsuccessfully in local environmentPartial #406