Skip to content

Conversation

@penguinolog
Copy link
Collaborator

  • Text was historically supported Text().pack() call
  • Update SelectableIcon for FIXED support
  • Force Edit to be Flow: need for cursor positioning
Checklist
  • I've ensured that similar functionality has not already been implemented
  • I've ensured that similar functionality has not earlier been proposed and declined
  • I've branched off the master or python-dual-support branch
  • I've merged fresh upstream into my branch recently
  • I've ran tox successfully in local environment
  • I've included docstrings and/or documentation and/or examples for my code (if this is a new feature)

@penguinolog penguinolog added the Feature Feature request/implementation label Sep 22, 2023
@penguinolog penguinolog requested a review from wardi September 22, 2023 09:13
@coveralls
Copy link

coveralls commented Sep 22, 2023

Pull Request Test Coverage Report for Build 7169240472

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 70.359%

Totals Coverage Status
Change from base Build 7168417392: 0.002%
Covered Lines: 7568
Relevant Lines: 10826

💛 - Coveralls

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed added to Edit but not Text?

@wardi
Copy link
Collaborator

wardi commented Sep 22, 2023

👍 Wanted to do this for a while now, but since so many things are based on Text it might cause some unexpected issues...

@penguinolog
Copy link
Collaborator Author

Need to collect more downstream projects to test…

* Force `Edit` to be `Flow`:
  need for cursor positioning
@github-actions github-actions bot added the docs Issues related to documentation label Dec 11, 2023
@penguinolog
Copy link
Collaborator Author

Tested and had no issues:
mitmproxy
socli
s-tui
nomadnet
pudb

@penguinolog penguinolog requested a review from wardi January 2, 2024 15:57
@penguinolog penguinolog merged commit a8dd718 into urwid:master Jan 2, 2024
@penguinolog penguinolog deleted the feature_fixed_text branch January 2, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Issues related to documentation Feature Feature request/implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants