Skip to content

Refactoring: use super() calls if possible - #611

Merged
penguinolog merged 1 commit into
urwid:masterfrom
penguinolog:refactor_super
Sep 22, 2023
Merged

penguinolog merged 1 commit into
urwid:masterfrom
penguinolog:refactor_super

Conversation

@penguinolog

Copy link
Copy Markdown
Collaborator
  • Stop using <ParentClass>.<method>.(self, ...) if only 1 parent / no MRO issues
  • Do not expand size argument if maxcol is not used directly
Checklist
  • I've ensured that similar functionality has not already been implemented
  • I've ensured that similar functionality has not earlier been proposed and declined
  • I've branched off the master or python-dual-support branch
  • I've merged fresh upstream into my branch recently
  • I've ran tox successfully in local environment
  • I've included docstrings and/or documentation and/or examples for my code (if this is a new feature)

* Stop using `<ParentClass>.<method>.(self, ...)` if only 1 parent / no MRO issues
* Do not expand `size` argument
  if `maxcol` is not used directly
@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 73.503%. remained the same when pulling b08ec53 on penguinolog:refactor_super into cce5326 on urwid:master.

@penguinolog
penguinolog merged commit 1ee971c into urwid:master Sep 22, 2023
@penguinolog
penguinolog deleted the refactor_super branch September 22, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants