Refactoring: Force ruff static checker for project - #639
Merged
Conversation
* do not use `assert` in production code * package files are not executable * use `isinstance` * stop checks like `if boolean == True: ...` * use `contextlib.suppress` * explicit return `None` in optionals * reduce amount of shadowed keywords (`next`, ...)
Pull Request Test Coverage Report for Build 6323621144
💛 - Coveralls |
Collaborator
|
@penguinolog you should give more time for code review. 4 minutes between opening a |
Collaborator
Author
|
I agree, but this PR from hell was 90% automatically generated |
Collaborator
|
That's even worse. Source code is for humans to read. |
6 tasks
|
It's great to see this extra linting of the project, but I'd agree re reviewing. Personally, I'd break these automated changes into multiple commits, each linting/fixing additional aspects. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
assertin production codeisinstanceif boolean == True: ...contextlib.suppressNonein optionalsnext, ...)Checklist
masterorpython-dual-supportbranchtoxsuccessfully in local environment