Skip to content

Refactor: fixup usage of contextlib.suppress() #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

ulidtko
Copy link
Collaborator

@ulidtko ulidtko commented Sep 27, 2023

Followup fixup to #639.

Checklist
  • I've ensured that similar functionality has not already been implemented
  • I've ensured that similar functionality has not earlier been proposed and declined
  • I've branched off the master or python-dual-support branch
  • I've merged fresh upstream into my branch recently
  • I've ran tox successfully in local environment
  • I've included docstrings and/or documentation and/or examples for my code (if this is a new feature)

@ulidtko ulidtko added refactoring Maintenance Project maintenance related labels Sep 27, 2023
@ulidtko ulidtko requested a review from penguinolog September 27, 2023 09:13
@github-actions github-actions bot removed the Maintenance Project maintenance related label Sep 27, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6323870897

  • 16 of 20 (80.0%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.386%

Changes Missing Coverage Covered Lines Changed/Added Lines %
urwid/canvas.py 4 5 80.0%
urwid/vterm.py 2 3 66.67%
urwid/util.py 1 3 33.33%
Totals Coverage Status
Change from base Build 6323654563: 0.0%
Covered Lines: 7518
Relevant Lines: 10290

💛 - Coveralls

Copy link
Collaborator

@penguinolog penguinolog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Historically I was almost always used OpenStack style of imports (import packages, not objects), but technically current PR should make code a bit more efficient

@ulidtko ulidtko merged commit b79afaf into urwid:master Sep 27, 2023
@ulidtko ulidtko deleted the refact/imported-contextlib-suppress branch September 27, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants