Skip to content

Expose widget and event_loop packages #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

penguinolog
Copy link
Collaborator

urwid.widget expose classes and methods,
which are not public directly:

  • WidgetContainerListContentsMixin
  • calculate_left_right_padding
  • calculate_top_bottom_filler
  • nocache_widget_render
  • nocache_widget_render_instance
  • normalize_align
  • normalize_height
  • normalize_valign
  • normalize_width
  • simplify_align
  • simplify_height
  • simplify_valign
  • simplify_width
Checklist
  • I've ensured that similar functionality has not already been implemented
  • I've ensured that similar functionality has not earlier been proposed and declined
  • I've branched off the master or python-dual-support branch
  • I've merged fresh upstream into my branch recently
  • I've ran tox successfully in local environment
  • I've included docstrings and/or documentation and/or examples for my code (if this is a new feature)

Fix: #491

`urwid.widget` expose classes and methods,
which are not public directly:

* `WidgetContainerListContentsMixin`
* `calculate_left_right_padding`
* `calculate_top_bottom_filler`
* `nocache_widget_render`
* `nocache_widget_render_instance`
* `normalize_align`
* `normalize_height`
* `normalize_valign`
* `normalize_width`
* `simplify_align`
* `simplify_height`
* `simplify_valign`
* `simplify_width`
@penguinolog penguinolog added the Feature Feature request/implementation label Sep 28, 2023
@coveralls
Copy link

coveralls commented Sep 28, 2023

Pull Request Test Coverage Report for Build 6341242230

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 74.38%

Totals Coverage Status
Change from base Build 6340771828: 0.002%
Covered Lines: 7514
Relevant Lines: 10286

💛 - Coveralls

@penguinolog penguinolog merged commit f482948 into urwid:master Sep 28, 2023
@penguinolog penguinolog deleted the expose_widget branch September 28, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature request/implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make WidgetContainerListContentsMixin public
3 participants