Skip to content

Introduce optional dependencies for package #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

penguinolog
Copy link
Collaborator

Simplify package installation with extras
Note trio and ZeroMQ event loop

Checklist
  • I've ensured that similar functionality has not already been implemented
  • I've ensured that similar functionality has not earlier been proposed and declined
  • I've branched off the master or python-dual-support branch
  • I've merged fresh upstream into my branch recently
  • I've ran tox successfully in local environment
  • I've included docstrings and/or documentation and/or examples for my code (if this is a new feature)

Fix: #441

Simplify package installation with extras
Note `trio` and `ZeroMQ` event loop
@penguinolog
Copy link
Collaborator Author

Note: this PR not introduces normal "requirements"

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6348494751

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.38%

Totals Coverage Status
Change from base Build 6341349895: 0.0%
Covered Lines: 7514
Relevant Lines: 10286

💛 - Coveralls

@penguinolog penguinolog added the Feature Feature request/implementation label Sep 29, 2023
@@ -31,6 +31,13 @@ To install using pip

pip install urwid

For advanced functionality extra requirements need to be installed.
Example for ZeroMQ event loop and LCD display:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a standard way to get a list of optional dependencies and their descriptions or should we add that here/in the docs?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They're described in pyproject.toml... No, don't duplicate in docs, will get outdated

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pip feature request is multiple years old, even solution with API is already added to the issue.
At this moment optional dependencies are not visible without API

@penguinolog penguinolog requested a review from wardi October 2, 2023 09:41
@penguinolog penguinolog merged commit ff8dc2c into urwid:master Oct 2, 2023
@penguinolog penguinolog deleted the optional_dependencies branch October 2, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature request/implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

should pyserial be listed in requirements.txt as dependency?
4 participants