-
Notifications
You must be signed in to change notification settings - Fork 319
Fix tutorial: rename attr
to urwid_attr
#653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Prevent stdlib `attr` shadowing in case of `sys.path` altered
@ulidtko without this PR changes, full regeneration of images in documentation is impossible :-( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting, is there something special about the name attr?
I mixed in my memory dataclasses with "attrs" package. import attr
@attr.s
class Config:
a: dict[str, int] = attr.ib(factory=dict, ... And other code is generated |
so this change isn't actually required then |
Scripts location is added to |
the docs/tutorial directory isn't added to sys.path and these are scripts not modules to be imported, right? |
It's added automatically on run as script.
As you can see, |
Prevent stdlib
attr
shadowing in case ofsys.path
alteredFix: #649
Checklist
master
orpython-dual-support
branchtox
successfully in local environment