use Hashable for signal identifier types - #669
Merged
Merged
Conversation
Signal identifiers types were specified as `str`, however the code only requires that they be `Hashable` in order to be used as dict keys. Closes urwid#668
Pull Request Test Coverage Report for Build 6795410726
💛 - Coveralls |
penguinolog
approved these changes
Nov 8, 2023
wardi
approved these changes
Nov 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signal identifiers types were specified as
str, however the code only requires that they beHashablein order to be used as dict keys.This pull request widens the type hints to
collections.abc.Hashablein order to reflect this fact.Closes #668