Skip to content

Fix #674 : old versions of setuptools_scm support - #675

Merged
penguinolog merged 2 commits into
urwid:masterfrom
penguinolog:setuptools_scm_api
Nov 21, 2023
Merged

penguinolog merged 2 commits into
urwid:masterfrom
penguinolog:setuptools_scm_api

Conversation

@penguinolog

@penguinolog penguinolog commented Nov 21, 2023 •

Copy link
Copy Markdown
Collaborator
  • Require setuptools_scm > 7.1
    Python 3.7 is minimally supported
    A lot of git bugfixes, including container support
  • Use compatible imports (use aliases)
Checklist
  • I've ensured that similar functionality has not already been implemented
  • I've ensured that similar functionality has not earlier been proposed and declined
  • I've branched off the master or python-dual-support branch
  • I've merged fresh upstream into my branch recently
  • I've ran tox successfully in local environment
  • I've included docstrings and/or documentation and/or examples for my code (if this is a new feature)

* Require `setuptools_scm` > 7.1
  Python 3.7 is minimally supported
  A lot of git bugfixes, including container support
* Use compatible imports (use aliases)
@coveralls

coveralls commented Nov 21, 2023 •

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 6941066391

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 74.158%

Totals Coverage Status
Change from base Build 6926967809: 0.002%
Covered Lines: 7516
Relevant Lines: 10278

💛 - Coveralls

@penguinolog
penguinolog merged commit 7f17032 into urwid:master Nov 21, 2023
@penguinolog
penguinolog deleted the setuptools_scm_api branch November 21, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] scm6 seems to generate unexpected version.py - ModuleNotFoundError when importing urwid (no __version__)

2 participants