Feature: Use module path + class name for loggers and init once#720
Merged
Conversation
* Add `logger` to all `Widget` instances (if properly subclassed)
Pull Request Test Coverage Report for Build 7336966911
💛 - Coveralls |
wardi
reviewed
Dec 27, 2023
| def __init__(self) -> None: | ||
| super().__init__() | ||
|
|
||
| self.logger = LOGGER.getChild(self.__class__.__name__) |
Collaborator
There was a problem hiding this comment.
this logger could be part of the class instead of the instance so it doesn't have to be tracked in every single widget
Collaborator
Author
There was a problem hiding this comment.
It will require metaclass usage, which is a bit overkill
Collaborator
There was a problem hiding this comment.
It could also be a Widget property or method that returns the logger
Collaborator
Author
There was a problem hiding this comment.
Technically once logger initializer, it stored in logging.Manager, so all instances of the same Widget class uses the same Logger.
Adding property may break downstream, because it will cause errors if downstream initialize logger itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
loggerto allWidgetinstances (if properly subclassed)Checklist
masterorpython-dual-supportbranchtoxsuccessfully in local environment