Skip to content

Remove unused deprecated "test_suite" directive from setup.py #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

penguinolog
Copy link
Collaborator

Checklist
  • I've ensured that similar functionality has not already been implemented
  • I've ensured that similar functionality has not earlier been proposed and declined
  • I've branched off the master or python-dual-support branch
  • I've merged fresh upstream into my branch recently
  • I've ran tox successfully in local environment
  • I've included docstrings and/or documentation and/or examples for my code (if this is a new feature)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7397352127

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 68.945%

Totals Coverage Status
Change from base Build 7397133223: 0.0%
Covered Lines: 7945
Relevant Lines: 11591

💛 - Coveralls

Copy link
Collaborator

@ulidtko ulidtko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is it deprecated? As #728 shows, it's also definitely not unused.

@penguinolog
Copy link
Collaborator Author

How is it deprecated? As #728 shows, it's also definitely not unused.

https://setuptools.pypa.io/en/latest/deprecated/commands.html#test-build-package-and-run-a-unittest-suite

Officially deprecated by setuptools

Copy link
Collaborator

@ulidtko ulidtko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, makes sense, there's tox.ini instead setting the tests entrypoint ✔️

@penguinolog penguinolog merged commit 2a85ef5 into urwid:master Jan 3, 2024
@penguinolog penguinolog deleted the cleanup_unused branch January 3, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants