Skip to content

Feature: Support FIXED-only widgets and FIXED rendering for PILE - #733

Merged
penguinolog merged 1 commit into
urwid:masterfrom
penguinolog:pile_support_fixed
Jan 10, 2024
Merged

Feature: Support FIXED-only widgets and FIXED rendering for PILE#733
penguinolog merged 1 commit into
urwid:masterfrom
penguinolog:pile_support_fixed

Conversation

@penguinolog

Copy link
Copy Markdown
Collaborator
  • PileError subclass WidgetError
  • Unify widget pack/render/input/cursor operation arguments collection
  • LineBox support FIXED widgets and FIXED rendering due to implementation

Note: FIXED operations are not using caching for calculation

Tests for Pile moved to the separate file test_pile from test_container

Checklist
  • I've ensured that similar functionality has not already been implemented
  • I've ensured that similar functionality has not earlier been proposed and declined
  • I've branched off the master or python-dual-support branch
  • I've merged fresh upstream into my branch recently
  • I've ran tox successfully in local environment
  • I've included docstrings and/or documentation and/or examples for my code (if this is a new feature)

* `PileError` subclass `WidgetError`
* Unify widget pack/render/input/cursor operation arguments collection
* `LineBox` support FIXED widgets and FIXED rendering due to implementation

Note: FIXED operations are not using caching for calculation

Tests for `Pile` moved to the separate file `test_pile` from `test_container`
@penguinolog penguinolog added the Feature Feature request/implementation label Jan 10, 2024
@penguinolog
penguinolog requested review from ulidtko and wardi January 10, 2024 11:12
@github-actions github-actions Bot added docs Issues related to documentation Tests Tests labels Jan 10, 2024
@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 7474063234

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 69.681%

Totals Coverage Status
Change from base Build 7474041165: 0.3%
Covered Lines: 8203
Relevant Lines: 11856

💛 - Coveralls

@wardi wardi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, I haven't gone over all the new tests but I assume the interface is somewhat consistent with the way Columns supports fixed widgets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Issues related to documentation Feature Feature request/implementation Tests Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants