Repository navigation
FIX Padding: support FIXED render mode if width is PACK - #734
Merged
Merged
Conversation
* Support the simplest sizing calculation for FIXED pack/render * Prevent exposing unsupported render mode * Raise human-friendly exception on incorrect CLIP render * Move padding tests from test_decoration to test_padding * Add `WidgetError` and `WidgetWarning` to the `widget_decoration` module to prevent circular imports Fix urwid#732
penguinolog
commented
Jan 10, 2024
| self.assertEqual(cols, canvas.cols()) | ||
| self.assertEqual(rows, canvas.rows()) | ||
| self.assertEqual( | ||
| [ |
Collaborator
Author
There was a problem hiding this comment.
real-world interface prototyping without manual elements calculation
Pull Request Test Coverage Report for Build 7478516931
💛 - Coveralls |
wardi
approved these changes
Jan 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support the simplest sizing calculation for FIXED pack/render
Prevent exposing unsupported render mode
Raise human-friendly exception on incorrect CLIP render
Move padding tests from test_decoration to test_padding
Add
WidgetErrorandWidgetWarningto thewidget_decorationmodule to prevent circular importsFix #732
Checklist
masterorpython-dual-supportbranchtoxsuccessfully in local environment