Feature: support FIXED render type for GridFLow - #738
Merged
Conversation
* GridFlow knows the amount and size of contents + size of spacing * Move GridFlow tests from test_container to test_grid_flow
wardi
reviewed
Jan 11, 2024
Collaborator
There was a problem hiding this comment.
the fixed widget color is on the right in all the others, better to be consistent
Collaborator
Author
There was a problem hiding this comment.
I copy-pasted background from urwid_widgets_1
Collaborator
There was a problem hiding this comment.
interesting. I wonder why I flipped the order between urwid_widgets_1 and urwid_widgets_2 🤔
Still, better to be consistent within the same diagram at least.
Pull Request Test Coverage Report for Build 7490198737
💛 - Coveralls |
wardi
approved these changes
Jan 11, 2024
wardi
left a comment
Collaborator
There was a problem hiding this comment.
other than the image color issue this looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
masterorpython-dual-supportbranchtoxsuccessfully in local environment