Skip to content

Feature: support FIXED render type for GridFLow - #738

Merged
penguinolog merged 2 commits into
urwid:masterfrom
penguinolog:grid_flow_support_fixed
Jan 11, 2024
Merged

Feature: support FIXED render type for GridFLow#738
penguinolog merged 2 commits into
urwid:masterfrom
penguinolog:grid_flow_support_fixed

Conversation

@penguinolog

Copy link
Copy Markdown
Collaborator
  • GridFlow knows the amount and size of contents + size of spacing
  • Move GridFlow tests from test_container to test_grid_flow
Checklist
  • I've ensured that similar functionality has not already been implemented
  • I've ensured that similar functionality has not earlier been proposed and declined
  • I've branched off the master or python-dual-support branch
  • I've merged fresh upstream into my branch recently
  • I've ran tox successfully in local environment
  • I've included docstrings and/or documentation and/or examples for my code (if this is a new feature)

* GridFlow knows the amount and size of contents + size of spacing
* Move GridFlow tests from test_container to test_grid_flow
@penguinolog penguinolog added the Feature Feature request/implementation label Jan 11, 2024
@penguinolog
penguinolog requested review from ulidtko and wardi January 11, 2024 14:12
@github-actions github-actions Bot added docs Issues related to documentation Tests Tests labels Jan 11, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the fixed widget color is on the right in all the others, better to be consistent

@penguinolog penguinolog Jan 11, 2024

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copy-pasted background from urwid_widgets_1

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting. I wonder why I flipped the order between urwid_widgets_1 and urwid_widgets_2 🤔

Still, better to be consistent within the same diagram at least.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@coveralls

coveralls commented Jan 11, 2024

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 7490198737

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 69.787%

Totals Coverage Status
Change from base Build 7489926545: 0.04%
Covered Lines: 8251
Relevant Lines: 11912

💛 - Coveralls

@wardi wardi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than the image color issue this looks good

@penguinolog
penguinolog merged commit 271b801 into urwid:master Jan 11, 2024
@penguinolog
penguinolog deleted the grid_flow_support_fixed branch January 11, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Issues related to documentation Feature Feature request/implementation Tests Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants