Feature: support proper repr and str for Canvas - #740
Merged
Merged
Conversation
Pull Request Test Coverage Report for Build 7500785068
💛 - Coveralls |
Better error messages and simpler debugging
penguinolog
force-pushed
the
feature_canvas_repr
branch
from
January 12, 2024 10:14
d5ebf56 to
74a3f7b
Compare
penguinolog
commented
Jan 12, 2024
Collaborator
Author
There was a problem hiding this comment.
applied auto-fotmatting
penguinolog
commented
Jan 12, 2024
|
|
||
|
|
||
| class CanvasTest(unittest.TestCase): | ||
| def test_basic_info(self): |
Collaborator
Author
There was a problem hiding this comment.
2 new tests for repr and str
penguinolog
commented
Jan 12, 2024
| def cct(self, widget, size, focus, expected): | ||
| got = urwid.CanvasCache.fetch(widget, urwid.Widget, size, focus) | ||
| assert expected==got, f"got: {got} expected: {expected}" | ||
| with self.subTest(widget=widget, size=size, focus=focus, expected=expected): |
Collaborator
Author
There was a problem hiding this comment.
use subTest to allow failing on multiple scenarios on CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better error messages and simpler debugging
Ignoring all exceptions in methods as it can cause infinite loop in error handlers
Checklist
masterorpython-dual-supportbranchtoxsuccessfully in local environment