Skip to content

Feature: Overlay typing and proper repr #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

penguinolog
Copy link
Collaborator

Better error messages and simpler debugging

  • move tests for Overlay from test_container to test_overlay
  • fix BigText issues found during Overlay testing
Checklist
  • I've ensured that similar functionality has not already been implemented
  • I've ensured that similar functionality has not earlier been proposed and declined
  • I've branched off the master or python-dual-support branch
  • I've merged fresh upstream into my branch recently
  • I've ran tox successfully in local environment
  • I've included docstrings and/or documentation and/or examples for my code (if this is a new feature)

Better error messages and simpler debugging
* move tests for `Overlay` from `test_container` to `test_overlay`
* fix `BigText` issues found during `Overlay` testing
@penguinolog penguinolog added the Feature Feature request/implementation label Jan 12, 2024
@github-actions github-actions bot added the Tests Tests label Jan 12, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7500921301

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 69.785%

Totals Coverage Status
Change from base Build 7492945541: -0.002%
Covered Lines: 8275
Relevant Lines: 11943

💛 - Coveralls

@penguinolog penguinolog merged commit 6cc6892 into urwid:master Jan 12, 2024
@penguinolog penguinolog deleted the overlay_typing_repr branch January 12, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature request/implementation Tests Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants