Skip to content

BUG: Columns support correct BOX render only if ALL BOX - #746

Merged
penguinolog merged 2 commits into
urwid:masterfrom
penguinolog:sizing_columns
Jan 15, 2024
Merged

penguinolog merged 2 commits into
urwid:masterfrom
penguinolog:sizing_columns

Conversation

@penguinolog

Copy link
Copy Markdown
Collaborator

Marking of BOX by 1 widget is incorrect.
Remove incorrect test scenarios and cover issue.

Checklist
  • I've ensured that similar functionality has not already been implemented
  • I've ensured that similar functionality has not earlier been proposed and declined
  • I've branched off the master or python-dual-support branch
  • I've merged fresh upstream into my branch recently
  • I've ran tox successfully in local environment
  • I've included docstrings and/or documentation and/or examples for my code (if this is a new feature)

Marking of BOX by 1 widget is incorrect.
Remove incorrect test scenarios and cover issue.
@github-actions github-actions Bot added the Tests Tests label Jan 15, 2024
@coveralls

coveralls commented Jan 15, 2024 •

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 7534061716

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 69.829%

Totals Coverage Status
Change from base Build 7526342559: -0.05%
Covered Lines: 8353
Relevant Lines: 12044

💛 - Coveralls

old python versions do not support cumulative names for Flag unions.
@penguinolog
penguinolog merged commit 24bbdcd into urwid:master Jan 15, 2024
@penguinolog
penguinolog deleted the sizing_columns branch January 15, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants