Skip to content

Feature: Filler can act as FLOW widget - #749

Merged
penguinolog merged 2 commits into
urwid:masterfrom
penguinolog:flow_filler
Jan 17, 2024
Merged

Feature: Filler can act as FLOW widget#749
penguinolog merged 2 commits into
urwid:masterfrom
penguinolog:flow_filler

Conversation

@penguinolog

Copy link
Copy Markdown
Collaborator
  • In case of wrapped FLOW widget
  • In case of GIVEN height

Rename test_decoration to test_filler: only Filler test present

Force all defined widgets errors to subclass WidgetError

Checklist
  • I've ensured that similar functionality has not already been implemented
  • I've ensured that similar functionality has not earlier been proposed and declined
  • I've branched off the master or python-dual-support branch
  • I've merged fresh upstream into my branch recently
  • I've ran tox successfully in local environment
  • I've included docstrings and/or documentation and/or examples for my code (if this is a new feature)

@penguinolog penguinolog added the Feature Feature request/implementation label Jan 17, 2024
@penguinolog
penguinolog requested a review from wardi January 17, 2024 09:24
@github-actions github-actions Bot added docs Issues related to documentation Tests Tests labels Jan 17, 2024
@coveralls

coveralls commented Jan 17, 2024

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 7553786921

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 69.909%

Totals Coverage Status
Change from base Build 7543314198: 0.06%
Covered Lines: 8356
Relevant Lines: 12031

💛 - Coveralls

* In case of wrapped FLOW widget
* In case of GIVEN height

Rename `test_decoration` to `test_filler`:
only `Filler` test present

Force all defined widgets errors to subclass `WidgetError`
@penguinolog
penguinolog merged commit 9e199e2 into urwid:master Jan 17, 2024
@penguinolog
penguinolog deleted the flow_filler branch January 17, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Issues related to documentation Feature Feature request/implementation Tests Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants