Fix regression: Columns render incorrect BOX/FLOW widgets height - #754
Merged
Conversation
* Fix and re-sort calculation * Add tests to cover regression * Add helper property `decoded_text` to `the` Canvas to stop a copy-paste decoded lines collection for tests Fix urwid#753
Pull Request Test Coverage Report for Build 7567814892
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
decoded_texttotheCanvas to stop a copy-paste decoded lines collection for testsFix: #753
Checklist
masterorpython-dual-supportbranchtoxsuccessfully in local environment