Skip to content

Fix regression: Columns render incorrect BOX/FLOW widgets height - #754

Merged
penguinolog merged 1 commit into
urwid:masterfrom
penguinolog:columns_render
Jan 18, 2024
Merged

Fix regression: Columns render incorrect BOX/FLOW widgets height#754
penguinolog merged 1 commit into
urwid:masterfrom
penguinolog:columns_render

Conversation

@penguinolog

@penguinolog penguinolog commented Jan 18, 2024

Copy link
Copy Markdown
Collaborator
  • Fix and re-sort calculation
  • Add tests to cover regression
  • Add helper property decoded_text to the Canvas to stop a copy-paste decoded lines collection for tests

Fix: #753

Checklist
  • I've ensured that similar functionality has not already been implemented
  • I've ensured that similar functionality has not earlier been proposed and declined
  • I've branched off the master or python-dual-support branch
  • I've merged fresh upstream into my branch recently
  • I've ran tox successfully in local environment
  • I've included docstrings and/or documentation and/or examples for my code (if this is a new feature)

* Fix and re-sort calculation
* Add tests to cover regression
* Add helper property `decoded_text` to `the` Canvas
  to stop a copy-paste decoded lines collection for tests

Fix urwid#753
@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 7567814892

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 69.896%

Totals Coverage Status
Change from base Build 7560036848: -0.002%
Covered Lines: 8364
Relevant Lines: 12040

💛 - Coveralls

@penguinolog
penguinolog merged commit c197e77 into urwid:master Jan 18, 2024
@penguinolog
penguinolog deleted the columns_render branch January 18, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Release 2.4.3 breaks rendering [BUG]

2 participants