Skip to content

Deduplicate code in frame module - #759

Merged
penguinolog merged 1 commit into
urwid:masterfrom
penguinolog:deduplicate
Jan 22, 2024
Merged

penguinolog merged 1 commit into
urwid:masterfrom
penguinolog:deduplicate

Conversation

@penguinolog

@penguinolog penguinolog commented Jan 22, 2024 •

Copy link
Copy Markdown
Collaborator
  • WidgetContainerMixin & WidgetContainerListContentsMixin copy/paste with container module
  • FrameContents subclasses MutableMapping do not make useless overloads

Unrelated: partial auto-format of functional tests

Checklist
  • I've ensured that similar functionality has not already been implemented
  • I've ensured that similar functionality has not earlier been proposed and declined
  • I've branched off the master or python-dual-support branch
  • I've merged fresh upstream into my branch recently
  • I've ran tox successfully in local environment
  • I've included docstrings and/or documentation and/or examples for my code (if this is a new feature)

@coveralls

coveralls commented Jan 22, 2024 •

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 7609808269

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 70.176%

Totals Coverage Status
Change from base Build 7609437155: 0.2%
Covered Lines: 8341
Relevant Lines: 11974

💛 - Coveralls

* `WidgetContainerMixin` & `WidgetContainerListContentsMixin`
  copy/paste with `container module`
* `FrameContents` subclasses `MutableMapping`
  do not make useless overloads

Unrelated: partial auto-format of functional tests
@penguinolog
penguinolog merged commit f26bd67 into urwid:master Jan 22, 2024
@penguinolog
penguinolog deleted the deduplicate branch January 22, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants