Skip to content

Columns special case: FIXED pack with not enough info #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

penguinolog
Copy link
Collaborator

In the case of weighted items without a size source, min_width can be used as width source.
Note: This behavior is only a special case.

This behavior should never be exposed in sizing to prevent incorrect render of widgets

Checklist
  • I've ensured that similar functionality has not already been implemented
  • I've ensured that similar functionality has not earlier been proposed and declined
  • I've branched off the master or python-dual-support branch
  • I've merged fresh upstream into my branch recently
  • I've ran tox successfully in local environment
  • I've included docstrings and/or documentation and/or examples for my code (if this is a new feature)

In the case of weighted items without a size source,
 min_width can be used as width source.
Note: This behavior is only a special case.

**This behavior should never be exposed in `sizing` to prevent incorrect render of widgets**
@penguinolog penguinolog added the Feature Feature request/implementation label Jan 31, 2024
@github-actions github-actions bot added the Tests Tests label Jan 31, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7724332926

  • 0 of 8 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 71.118%

Files with Coverage Reduction New Missed Lines %
urwid/widget/columns.py 1 91.14%
Totals Coverage Status
Change from base Build 7715077568: 0.02%
Covered Lines: 8770
Relevant Lines: 12439

💛 - Coveralls

@penguinolog penguinolog merged commit edeb6ee into urwid:master Jan 31, 2024
@penguinolog penguinolog deleted the columns_special_case_fixed branch January 31, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature request/implementation Tests Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants